This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Fix issue on Chromium based browsers. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
jdalton
reviewed
Oct 22, 2016
| // ensure that content in iframe is processed by executing on next tick | ||
| setTimeout(function() { | ||
| // the element the charts are inserted into | ||
| me.container = query('#bs-chart', idoc)[0]; |
There was a problem hiding this comment.
Does the me.container assignment need to be in the setTimeout?
There was a problem hiding this comment.
Yeah, it should be inside. Previously me.container was undefined as the iframe hadn't updated yet. Placing a timeout of 1 should get the code to run in the next tick, and the iframe should be updated by then.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jsperf/jsperf.com#235 (comment).
Ref. jsperf/jsperf.com#235.
I'm not too sure whether the timeout of 1 is enough, and I don't really have time to check ¯_(ツ)_/¯