Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Commit

Permalink
Drop Narwhal from testing.
Browse files Browse the repository at this point in the history
  • Loading branch information
jdalton committed Jun 23, 2014
1 parent 334847a commit 39d320c
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
4 changes: 0 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ matrix:
env: ISTANBUL=true
- node_js: "0.10"
env: BIN="phantomjs"
- node_js: "0.10"
env: BIN="narwhal"
- node_js: "0.10"
env: BIN="rhino"
- node_js: "0.10"
Expand All @@ -30,8 +28,6 @@ branches:
before_install:
- "[ $SAUCE_LABS == false ] || npm i chalk@\"^0.4.0\" ecstatic@\"^0.5.0\" request@\"^2.36.0\" sauce-tunnel@\"^2.0.0\""
- "[ $ISTANBUL == false ] || npm i -g coveralls@\"^2.10.0\" istanbul@\"^0.2.0\""
- "[ $BIN != 'narwhal' ] || (wget http:https://benchmarkjs.com/_travis/narwhal-0.3.2.zip && sudo unzip narwhal-0.3.2 -d /opt/ && rm narwhal-0.3.2.zip)"
- "[ $BIN != 'narwhal' ] || (sudo ln -s /opt/narwhal-0.3.2/bin/narwhal /usr/local/bin/narwhal && sudo chmod +x /usr/local/bin/narwhal)"
- "[ $BIN != 'rhino' ] || (sudo mkdir /opt/rhino-1.7R5 && sudo wget -O /opt/rhino-1.7R5/js.jar http:https://benchmarkjs.com/_travis/rhino-1.7R5.jar)"
- "[ $BIN != 'rhino' ] || (echo -e '#!/bin/sh\\njava -jar /opt/rhino-1.7R5/js.jar $@' | sudo tee /usr/local/bin/rhino && sudo chmod +x /usr/local/bin/rhino)"
- "[ $BIN != 'ringo' ] || (wget http:https://benchmarkjs.com/_travis/ringojs-0.9.zip && sudo unzip ringojs-0.9 -d /opt && rm ringojs-0.9.zip)"
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Please make sure to [search the issue tracker](https://github.com/bestiejs/bench
Include updated unit tests in the `test` directory as part of your pull request.

You can run the tests from the command line via `node test/test`, or open `test/index.html` in a web browser.
The `test/run-test.sh` script attempts to run the tests in [Rhino](https://developer.mozilla.org/en-US/docs/Rhino), [Narwhal](https://github.com/280north/narwhal), [RingoJS](http:https://ringojs.org/), [PhantomJS](http:https://phantomjs.org/), and [Node](http:https://nodejs.org/), before running them in your default browser.
The `test/run-test.sh` script attempts to run the tests in [Rhino](https://developer.mozilla.org/en-US/docs/Rhino), [RingoJS](http:https://ringojs.org/), [PhantomJS](http:https://phantomjs.org/), and [Node](http:https://nodejs.org/), before running them in your default browser.

## Coding Guidelines

Expand Down
2 changes: 1 addition & 1 deletion test/run-test.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cd "$(dirname "$0")"

for cmd in rhino "rhino -require" narwhal ringo phantomjs node; do
for cmd in rhino "rhino -require" ringo phantomjs node; do
echo "Testing in $cmd..."
$cmd test.js
echo ""
Expand Down

4 comments on commit 39d320c

@mathiasbynens
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rationale?

@jdalton
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's dead, no real value in testing it beyond bragging rights.

@mathiasbynens
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well drop Rhino, then. No new releases, even after they promised to do one “soon” back in 2012: https://bugzilla.mozilla.org/show_bug.cgi?id=775566#c2

@jdalton
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yap, I'd like to drop at the time we add nashorn.

Please sign in to comment.