Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix theme switch issue #746

Closed
wants to merge 1 commit into from
Closed

Conversation

zhang-ning
Copy link

fix the issue on after theme loaded in setting can't be switch back

@jesperronn
Copy link

Two things:

I am not sure I can reproduce the error you describe. on https://stackedit.io/editor I can easily switch back to default theme after changning theme. It works for me. Describe exactly your steps to produce the error.

Secondly, I think you should review your code and reindent it. Also, be consistent to decide if you are using _themeStyle or window.themeStyle

@zhang-ning
Copy link
Author

@jesperronn it will be reproduced by fellow Blue -> Default -> Blue -> Default

@benweet benweet closed this Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants