Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax keyboard triggers: We want reload, not HR #704

Closed
wants to merge 1 commit into from

Conversation

jesperronn
Copy link

Big problem in my daily use of Stackedit. When I want to reload page, Stackedit creates an HR element. This pull-request removes the bindings of:

  • CMD+R Fixed so that keyboard mappings don't bind to create horizontal rule
  • CMD+L Fixed so that we can type new address in browser and not open link dialog

CMD+R Fixed so that keyboard mappings dont bind to create horizontal rule
CMD+L Fixed so that we can type new address in browser and not open link dialog
@benweet
Copy link
Owner

benweet commented Feb 22, 2015

This is the default behavior as on StackOverflow. You can still configure that in Settings>Extensions>Shortcuts.

@benweet benweet closed this Feb 22, 2015
@jesperronn
Copy link
Author

This is the default behavior as on StackOverflow.

Yes it's default behaviour for StackOverflow when in an editor window. The main difference is that Stackedit is the full window that always has focus. StackOverflow is a tiny editor being a part of a bigger context on the page. You go into the editor, and you get done. And you get back out of edit mode.

For Stackedit, you stay in edit mode. I would prefer the defaults being opposite: Disable it and let people use the settings.

This way, Stackedit editor could better live in another context, for instance, as an editor part of a bigger page.

Thanks for your considerations, I respect you are keeping Stackedit shortcuts as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants