Improve dockerfile #612
Improve dockerfile #612
Conversation
- Use docker library version of node - Assume dockerfile lives with sourcecode - Assume server can be started with `npm start` aka `node server.js` - Assumes all dependencies are listed in `package.json`
|
You'll notice that in the build history, there are a lot of failed builds. This is due to one build pointing to a nonexistent tag for testing, and 2 of the other tags are failing due to #596. |
|
Looks good to me. Could you upgrade to 0.12-onbuild? |
|
Done. This will now target version 0.12.x of node. Another option to take into consideration is targeting |
|
Thx. Just setup a repo in Docker Hub to test that: |
|
|
This significantly simplifies the dockerfile for stackedit by using library/node as its base.
This simplification works because
npm installandnpm startare called by the base image.This will always create the container using the source code the dockerfile is "living with" and will not pull from git separately. Versioning is handled by specifying on dockerhub what git tagged versions should be made available.
To test I set up a build repo on dockerhub with several testing tags. If you wanted to set up an "official" stackedit build repo its pretty easy. Just setup the automatic builds as follows, where "Name" is the git tag to use code from and "Docker Tag Name" is the version name used by docker.
I believe this really is the best way to do this and should require virtually no future maintenance.