Dockerfile

[manbearwiz]

Sorry for the commit mess. Thankfully github is good at summarizing. That's just me not knowing how PRs and forks work with github yet.

This dockerfile uses the "trusted" Node.js Build and the latest release tarball. I suppose it could clone from git if that is prefered, but I think it makes more sense to use the released version as that is less likely to break on some random day.

$ sudo docker build -t benweet/stackedit
$ sudo docker run -d -p 3000:3000 --name stackedit benweet/stackedit

[benweet]

Is it necessary to hard code the version number?

[manbearwiz]

There are a few ways to get around this; none of which seem perfect.

1. ENV $VARIABLES

   Looking at this issue It looks like once Docker 1.3 is released, I can do this:

   ENV STACKEDIT_VERSION 4.1.1
   
   RUN wget -qO- https://github.com/benweet/stackedit/archive/v${STACKEDIT_VERSION}.tar.gz | tar xz
   
   WORKDIR stackedit-${STACKEDIT_VERSION}
   

   This allows users to easily select an alternate version:

   sudo docker run -d --env STACKEDIT_VERSION=4.1.1 -p 3000:3000 --name stackedit benweet/stackedit`
   

   However the version should still be updated when there is a new release.

2. Static URL
   If the latest release tarball was hosted at a static url, ex. https://stackedit.io/source.tar.gz, it wouldn't rely on release names. However this would mean more traffic for your site and still needing to update said archive file.

3. Latest tag
   I could use git to find and clone the latest tag. This would mean installing git and prove troublesome if you tag a non release version, alpha, rc, etc.

[manbearwiz]

Thinking about this a bit, I really think option 1 above makes the most sense. You should still update the version on new releases; however, it wouldn't be urgent, as users can easily pick any tagged version they want at run time. Also with a little modification I can make it work on the current version of docker

FROM dockerfile/nodejs

ENV STACKEDIT_VERSION 4.1.1

WORKDIR /tmp

RUN \
  wget -qO- https://github.com/benweet/stackedit/archive/v${STACKEDIT_VERSION}.tar.gz | tar xz && \
  mv stackedit-${STACKEDIT_VERSION} stackedit

WORKDIR stackedit

RUN \
  npm install && \
  node_modules/bower/bin/bower install --allow-root --production --config.interactive=false

CMD node server.js

EXPOSE 3000

Thoughts?

[manbearwiz]

I'm going to close this PR and start new. I think I've got a solution to this figured out, and if it pans out I'll create a new PR from that.