Upgrade to mermaid.js 8.4.0 #1586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09f5406
to
c499e70
Compare
Signed-off-by: Amin Wang <[email protected]>
c499e70
to
6c24ea3
Compare
|
mermaid.js docs mentions that there are some non-backward compatible changes when migrating from versions below 8.2.0 - has this been considered? If so, this should be merged as it solves multiple open issues - #1583, #1587, and #1601 to name a few. And also latest version as of now (June 5th 2020) is 8.5.1. Maybe we can upgrade to that version directly. |
|
Fixed with v5.14.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I found mermaid.js has new version. I thought we can upgrade it.
Signed-off-by: Amin Wang [email protected]