Method extractions in cleditHighlighter
#1556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows practice of naming rather than commenting and example of `highlight/1` in same file
Follows practice of naming rather than commenting and example of `highlight/1` in same file Extracts `removeUnauthorizedSiblingNodesFrom/1` and called helper `lacksSection/1` Wondering if this function should just be called `removeSectionlessNodesFrom` as it’s local and sectionlessness seems to be the only rejection criterion
|
Well that's embarrassing. I'll fix the linting today or tomorrow. Was trying to hurry up and get this clean before moving onto next part of day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really simple stuff. For me this is a small improvement, but I'd be interested in some guidance on the intended file organization in general and the function that is currently called
removeUnauthorizedSiblingNodesFromspecifically.If this looks worse to you rather than better it's no problem :)