Multi Stage Dockerfile #1416
Closed
Multi Stage Dockerfile #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split the Docker image so that one, big, image does the building and then an alpine based image with node installed has the compiled binaries. * This decreases the image from around 4.5GB (uncompressed) to around 680MB (uncompressed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was playing around with the Docker image I noticed that the image was huge (4.6GB uncompressed, 1.9GB compressed).
I tested out building this with a Multi Stage Dockerfile (your ubuntu based image as the builder and mhart/alpine-node as the executor)
The final image size is:
Also, there's the added benefit of fewer CVE's
Let me know what you think