Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of tables, use divs + css grid #78

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

benvinegar
Copy link
Owner

This fixes the background color on table rows not going all the way across the row, which was a limitation of table elements.

After this PR, the background color actually takes up X% of the row.

Before:

image

After:
image

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.14%. Comparing base (3d71568) to head (4538a9a).

Files Patch % Lines
app/components/ui/table.tsx 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   79.05%   79.14%   +0.09%     
==========================================
  Files          18       18              
  Lines        2253     2263      +10     
  Branches      146      148       +2     
==========================================
+ Hits         1781     1791      +10     
  Misses        467      467              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benvinegar benvinegar merged commit 405c228 into main Jun 3, 2024
3 checks passed
@benvinegar benvinegar deleted the tables-to-divs branch June 3, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant