Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier config + run on all files + add to pre-commit hook #34

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

benvinegar
Copy link
Owner

Per @calirvine's request, adding Prettier to the project. The only config option is tabWidth: 4, which is how the project was already coded (and is just a reflection of my personal preference).

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 179 lines in your changes are missing coverage. Please review.

Comparison is base (7e83730) 71.78% compared to head (ef4ca23) 72.38%.

Files Patch % Lines
app/root.tsx 0.00% 38 Missing and 1 partial ⚠️
public/tracker.js 0.00% 39 Missing ⚠️
app/components/ui/card.tsx 58.20% 28 Missing ⚠️
app/components/TimeSeriesChart.tsx 54.76% 19 Missing ⚠️
app/components/ui/table.tsx 83.87% 15 Missing ⚠️
app/components/ui/select.tsx 90.69% 12 Missing ⚠️
app/analytics/query.ts 94.14% 11 Missing ⚠️
server.ts 0.00% 7 Missing ⚠️
app/routes/admin-redirect.tsx 0.00% 3 Missing ⚠️
app/routes/dashboard.tsx 97.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   71.78%   72.38%   +0.60%     
==========================================
  Files          18       18              
  Lines        1701     1934     +233     
  Branches      110      115       +5     
==========================================
+ Hits         1221     1400     +179     
- Misses        474      528      +54     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benvinegar benvinegar merged commit f312779 into main Feb 4, 2024
3 checks passed
@benvinegar benvinegar deleted the prettier branch February 4, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant