Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error stack trace (PhantomJS/SlimerJS) #188

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

immoh
Copy link
Contributor

@immoh immoh commented Nov 20, 2018

This PR modifies this output

;; ======================================================================
;; Testing with Phantom:

ReferenceError: Can't find variable: Map

  phantomjs:https://code/phantom8526881425544510795.js:81 in onError
Subprocess failed

to include stack trace

;; ======================================================================
;; Testing with Phantom:

ReferenceError: Can't find variable: Map

  phantomjs:https://code/phantom5344940102494846597.js:81 in onError
  file:https:///Users/iheikkinen/src/foobar/target/out/cljsjs/react-dom/development/react-dom.inc.js:6075
  file:https:///Users/iheikkinen/src/foobar/target/out/cljsjs/react-dom/development/react-dom.inc.js:15
Subprocess failed

so that troubleshooting is a bit easier.

Copy link
Collaborator

@miikka miikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@miikka miikka merged commit 4866edc into bensu:master Nov 20, 2018
@miikka
Copy link
Collaborator

miikka commented Nov 20, 2018

I figured out that it's a good time to create a release, so this is in [lein-doo "0.1.11"].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants