Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Incident - reportedBy store the currently logged in user id #3

Merged
merged 9 commits into from
Sep 9, 2022
Merged

Fix Incident - reportedBy store the currently logged in user id #3

merged 9 commits into from
Sep 9, 2022

Conversation

xhefribala
Copy link

@xhefribala xhefribala commented Sep 9, 2022 •
edited
Loading

Fixes HospitalRun#2539

Changes proposed in this pull request:

  • add 'reportedBy' and 'reportedByUserID' in const incidentRequest in useReportIncident.test to have satisfactory unit testing
  • removed reportedBy:'some users' in 'useReportIncident' as not needed
  • added react redux use selector in 'reportIncident.tsx' in order to read userFullName from redux Store
  • defined type of reportUserByUserID in incident.ts because was missing the property in reportIncident.tsx

@xhefribala xhefribala marked this pull request as ready for review September 9, 2022 04:05
@bennymelb bennymelb merged commit 7f3f3f8 into bennymelb:bennylo/fe-issue-2539 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@xhefribala @bennymelb