Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to v18 #280

Merged
merged 2 commits into from
Feb 17, 2024
Merged

feat: migrate to v18 #280

merged 2 commits into from
Feb 17, 2024

Conversation

JosefBredereck
Copy link
Contributor

@JosefBredereck JosefBredereck commented Feb 17, 2024 •
edited
Loading

Please make a test on your side. I tried to follow the contribution guide and everything worked in my current application.

I had difficulties running the tests on my Windows machine and with the build of migrations.

fixes: #279

@bennymeg bennymeg changed the base branch from master to feature/v18 February 17, 2024 17:37
@bennymeg bennymeg merged commit cdf4f21 into bennymeg:feature/v18 Feb 17, 2024
@JosefBredereck JosefBredereck deleted the feature/v18 branch February 18, 2024 10:58
@brnbs
Copy link

brnbs commented Mar 14, 2024

@bennymeg can you please make an npm release? The currently available version is not compatible with nx 18:

npm WARN Could not resolve dependency:
npm WARN peer @nx/workspace@"^17" from [email protected]
npm WARN node_modules/nx-electron
npm WARN   dev nx-electron@"^17.0.1" from the root project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nx-electron is incompatible with the latest nx version 18.0.4
3 participants
@JosefBredereck @brnbs @bennymeg