This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
Merge vpicaver's fork #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue benlau#18
This fixes issue benlau#21
…different thread then watcher - This commit also adds canceled to observe().context() - Updated to the documentation going in more detail about using context()
# Conflicts: # asyncfuture.h
Fixed Observable().subscribe(...).future() aka DeferredFuture should forward progress on chained pipeline benlau#31
AsyncFuture now automatically forwards cancel to parent futures including QtConcurrent::mapping
- Also fixed progress range for asyncfuture
When a deferred is completed with a future it now pushes cancel to the completed future.
These suppression aren't needed for Qt 5.12. There seem to be a bug in Qt 5.9. The suppression file already contains similar suppressions.
|
This fixes multiple bugs found in the master. @benlau do you think you can review this and merge it in so we can close some of the existing bugs? |
|
@benlau Do you have any suggestions on what I need to go to get this merged? |
|
Awesome thanks!
…On Mon, Mar 1, 2021 at 7:49 AM Ben Lau ***@***.***> wrote:
Merged #38 <#38> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#38 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKKDA37AB6ICUSN2NMBWVDTBOEPHANCNFSM4XVN32NQ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.