feat: Add v8::TypedArray::length (denoland#1166)

benjamn · Jan 13, 2023 · 5f037a1 · 5f037a1
1 parent b7cfc58
commit 5f037a1
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/src/binding.cc b/src/binding.cc
@@ -464,6 +464,9 @@ uint32_t v8__ScriptCompiler__CachedDataVersionTag() {
  return v8::ScriptCompiler::CachedDataVersionTag();
 }
 
+size_t v8__TypedArray__Length(const v8::TypedArray* self) { 
+ return ptr_to_local(self)->Length(); 
+}
 size_t v8__TypedArray__kMaxLength() { return v8::TypedArray::kMaxLength; }
 
 bool v8__Data__EQ(const v8::Data& self, const v8::Data& other) {

diff --git a/src/typed_array.rs b/src/typed_array.rs
@@ -7,6 +7,7 @@ use crate::TypedArray;
 
 extern "C" {
  fn v8__TypedArray__kMaxLength() -> size_t;
+ fn v8__TypedArray__Length(this: *const TypedArray) -> size_t;
 }
 
 impl TypedArray {
@@ -17,6 +18,13 @@ impl TypedArray {
  pub fn max_length() -> usize {
  unsafe { v8__TypedArray__kMaxLength() }
  }
+
+ /// Number of elements in this typed array
+ /// (e.g. for Int16Array, |ByteLength|/2).
+ #[inline(always)]
+ pub fn length(&self) -> usize {
+ unsafe { v8__TypedArray__Length(self) }
+ }
 }
 
 macro_rules! typed_array {

diff --git a/tests/test_api.rs b/tests/test_api.rs
@@ -4268,36 +4268,47 @@ fn typed_array_constructors() {
 
  let t = v8::Uint8Array::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_uint8_array());
+ assert_eq!(t.length(), 0);
 
  let t = v8::Uint8ClampedArray::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_uint8_clamped_array());
+ assert_eq!(t.length(), 0);
 
  let t = v8::Int8Array::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_int8_array());
+ assert_eq!(t.length(), 0);
 
  let t = v8::Uint16Array::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_uint16_array());
+ assert_eq!(t.length(), 0);
 
  let t = v8::Int16Array::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_int16_array());
+ assert_eq!(t.length(), 0);
 
  let t = v8::Uint32Array::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_uint32_array());
+ assert_eq!(t.length(), 0);
 
  let t = v8::Int32Array::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_int32_array());
+ assert_eq!(t.length(), 0);
 
  let t = v8::Float32Array::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_float32_array());
+ assert_eq!(t.length(), 0);
 
  let t = v8::Float64Array::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_float64_array());
+ assert_eq!(t.length(), 0);
 
  let t = v8::BigUint64Array::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_big_uint64_array());
+ assert_eq!(t.length(), 0);
 
  let t = v8::BigInt64Array::new(scope, ab, 0, 0).unwrap();
  assert!(t.is_big_int64_array());
+ assert_eq!(t.length(), 0);
 
  // TypedArray::max_length() ought to be >= 2^30 < 2^32 in 64 bits
  #[cfg(target_pointer_width = "64")]