forked from denoland/rusty_v8
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: v8::Isolate::snapshot_creator instead of v8::SnapshotCreator (
denoland#1098) This commit removes "v8::SnapshotCreator" in favor of "v8::Isolate::snapshot_creator" API. All methods from "v8::SnapshotCreator" are now available on the "v8::Isolate". If a method is called and isolate was not set up as a snapshot creator then it will panic. This commit gets rid of long standing unsoundness in typing that allowed to easily induce a panic or segfault if a user didn't use snapshot creator API properly.
- Loading branch information
1 parent
213305b
commit 4b704ed
Showing
5 changed files
with
160 additions
and
66 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.