Fix pretty-printing strings with \u2028 or \u2029 #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two characters are considered ordinary characters by JSON but line terminators by ECMAScript (prior to ES2019). When pretty-printing a string containing either character, JSON.stringify leaves it unescaped. The result in recast.prettyPrint is that fromString, which follows ECMAScript definitions, converts it mistakenly to a newline character. Escaping these characters manually when the intent is to generate ECMAScript (rather than JSON) eliminates the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two characters are considered ordinary characters by JSON but line
terminators by ECMAScript (prior to ES2019). When pretty-printing a
string containing either character, JSON.stringify leaves it unescaped.
The result in recast.prettyPrint is that fromString, which follows
ECMAScript definitions, converts it mistakenly to a newline character.
Escaping these characters manually when the intent is to generate
ECMAScript (rather than JSON) eliminates the problem.