Expose frozen wrap(...).options on functions returned by wrap
#504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Mar 21, 2023
Thanks to benjamn/optimism#504, we no longer need mocking to find out the options used when wrapping functions. This mocking was introduced in #8107, when there was no better option.
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Mar 21, 2023
Thanks to benjamn/optimism#504, we no longer need mocking to find out the options used when wrapping functions. This mocking was introduced in #8107, when there was no better option.
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Mar 21, 2023
Thanks to benjamn/optimism#504, we no longer need mocking to find out the options used when wrapping functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing these
wrapped.optionsshould eliminate the need to mock theoptimismpackage for Apollo Client tests, introduced by apollographql/apollo-client#8107.