Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #62

Merged
merged 3 commits into from
Jan 23, 2021
Merged

Add tests #62

merged 3 commits into from
Jan 23, 2021

Conversation

namenyi
Copy link
Collaborator

@namenyi namenyi commented Jan 23, 2021

  • add 2 extra test cases
  • fix the alphabetical order of currencies

davidporos92
davidporos92 approved these changes Jan 23, 2021
View reviewed changes
Copy link

@davidporos92 davidporos92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea to have a test for the alphabetical order 👍

@namenyi namenyi merged commit 6dc96f7 into master Jan 23, 2021
@namenyi namenyi deleted the add_tests branch January 23, 2021 13:32
@namenyi
Copy link
Collaborator Author

namenyi commented Jan 23, 2021

Released in v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporos92 davidporos92 davidporos92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@namenyi @davidporos92