Defer firing on_select event in GTK OptionContainer #2713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2703.
Under GTK, the
current_page()
API doesn't return the current value while still in theon_select
handler; as a result, a user-space event handler trying to retrieve the current tab will get the wrong result.This change defers the execution of the
on_select
handler so thatcurrent_page()
is guaranteed to return the correct result.PR Checklist: