This repository has been archived by the owner on May 31, 2020. It is now read-only.
divmod() support for complex args and wrong number of args #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phildini
reviewed
May 24, 2017
| @@ -8,27 +8,6 @@ class DivmodTests(TranspileTestCase): | |||
| class BuiltinDivmodFunctionTests(BuiltinFunctionTestCase, TranspileTestCase): | |||
| functions = ["divmod"] | |||
|
|
|||
| not_implemented = [ | |||
There was a problem hiding this comment.
All these tests just work? Huh... That's... suspicious? Maybe that's true! If so, wow!
There was a problem hiding this comment.
Makes sense, though - if the error message has been corrected, then most of these will have been failing because the message was wrong.
|
They didn't work until I fixed the exception string! But that seems to have been all they needed. |
freakboy3742
approved these changes
May 25, 2017
| @@ -8,27 +8,6 @@ class DivmodTests(TranspileTestCase): | |||
| class BuiltinDivmodFunctionTests(BuiltinFunctionTestCase, TranspileTestCase): | |||
| functions = ["divmod"] | |||
|
|
|||
| not_implemented = [ | |||
There was a problem hiding this comment.
Makes sense, though - if the error message has been corrected, then most of these will have been failing because the message was wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.