Skip to content
This repository has been archived by the owner on May 31, 2020. It is now read-only.

Implement the sentinel variant of the 'iter' builtin #539

Merged
merged 3 commits into from
May 24, 2017
Merged

Implement the sentinel variant of the 'iter' builtin #539

merged 3 commits into from
May 24, 2017

Conversation

Nurdok
Copy link
Contributor

@Nurdok Nurdok commented May 24, 2017

The sentinel behavior is described here: https://docs.python.org/2/library/functions.html#iter

glasnt
glasnt suggested changes May 24, 2017
View reviewed changes
Copy link
Member

@glasnt glasnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I'm not sure if there's a more complex test that can be added in here, though, to ensure everything works as expected.

@Nurdok
Copy link
Contributor Author

Nurdok commented May 24, 2017

@glasnt I added another test (and a fix).

@glasnt glasnt merged commit 5a4364e into beeware:master May 24, 2017
@Nurdok Nurdok deleted the feature/iter-sentinel branch May 24, 2017 21:10
@Nurdok
Copy link
Contributor Author

Nurdok commented May 24, 2017

@glasnt Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@glasnt glasnt glasnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nurdok @glasnt