This repository has been archived by the owner on May 31, 2020. It is now read-only.
fix: Added fix for lshift and rshift #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
reviewed
May 22, 2017
batavia/types/Bool.js
Outdated
| @@ -515,6 +515,12 @@ Bool.prototype.__lshift__ = function(other) { | |||
| return new types.Int(0) | |||
| } | |||
| } else if (types.isinstance(other, types.Int)) { | |||
| if(other.valueOf() < 0) { | |||
There was a problem hiding this comment.
The linter is probably going to yell at you about having spaces after if (here and below).
There was a problem hiding this comment.
Thanks for catching that! Updating code...
swenson
approved these changes
May 22, 2017
|
I've just pushed a fix for the linting issues. Will merge when CI goes green |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an expected failure and makes rshift and lshift work with Booleans.
cc @toastdriven