Fix typo and add sudo #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix command in line 42 (it must be "npm" not "nmp") Fix typo in line 69 (it must be "pencopotan" not "pemasangan") Add sudo in line 72 (it must be "un" alias for uninstall not just "u') Add sudo on command in line 76 (MacOS need sudo for delete that folder)
yrojx
commented
Jul 7, 2020
| case $1 in | ||
| "Green Tunnel" ) | ||
| confirm "-x $(command -v gt)" "Green Tunnel" "npm u -g gt" | ||
| confirm "-x $(command -v gt)" "Green Tunnel" "npm un -g gt" |
There was a problem hiding this comment.
"u" is not alias for uninstall. Instead we can use: remove, rm, r, un, unlink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix command in line 42 (it must be "npm" not "nmp")
Fix typo in line 69 (it must be "pencopotan" not "pemasangan")
Add sudo in line 72 (it must be "un" alias for uninstall not just "u')
Add sudo on command in line 76 (MacOS need sudo for delete that folder)