Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser option untuk non-chrome Linux user #287

Merged
merged 5 commits into from
Feb 9, 2021

Conversation

fijar-lazuardy
Copy link
Contributor

@fijar-lazuardy fijar-lazuardy commented Feb 8, 2021

Update untuk non-chrome Linux user.
Sejauh ini hanya masih tersedia 3 opsi: Google Chrome, Firefox, dan Brave Browser.

Tested on:
OS: Ubuntu 20.04. LTS
Kernel: 5.8.0-41-generic

Test preview
Command:
image

Browser:
image

Tmux tunnel
image

@fijar-lazuardy fijar-lazuardy changed the title Update browser option untuk non-chrome user Update browser option untuk non-chrome Linux user Feb 8, 2021
Copy link
Collaborator

@icaksh icaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

udah bagus konsepnya cuma ada review:

  1. Firefox nggak bakal jalan karena flagsnya berbeda (https://linux.die.net/man/1/firefox)

ada dua fix untuk hal ini, yaitu bisa dihapus untuk firefox atau menambah setting biar firefox dapat jalan sebelum saya merge

Terima kasih atas partisipasinya

;;
esac
loadin 0.01 "Tunggu sebentar, sedang membuka $browser"
tmux send-keys -t 2 "$browser netflix.com --proxy-server=127.0.0.1:$random" Enter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bagian ini hanya work untuk browser based chromium..
firefox harus ada profil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

menarik, soalnya tadi saya coba di machine saya work just fine, tapi harusnya gampang di-fix sih

@icaksh icaksh self-assigned this Feb 8, 2021
Copy link
Contributor Author

@fijar-lazuardy fijar-lazuardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untuk fix sementara harusnya ini work just fine sih

Comment on lines 533 to 537
if [[ "$browser" == "firefox" ]]; then
tmux send-keys -t 2 "$browser netflix.com --proxy-server=127.0.0.1:$random -ProfileManager" Enter
else
tmux send-keys -t 2 "$browser netflix.com --proxy-server=127.0.0.1:$random" Enter
fi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Karena sepertinya ga bisa nge-list profile Firefox langsung dari terminal, alternatifnya saya pakai flag -ProfileManager biar user bisa pilih manual profile saat launch browser

Testing:
image

Pop-up prompt:
image

image

Test buka reddit:
image

user_pref("network.proxy.http_port", 1945);
74 user_pref("network.proxy.type", 1);
@icaksh
Copy link
Collaborator

icaksh commented Feb 9, 2021

Dah fixed

@icaksh icaksh merged commit ff67bcb into bebasid:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants