Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline code change broke code paragraphs #12

Open
tbm opened this issue May 12, 2020 · 3 comments
Open

Inline code change broke code paragraphs #12

tbm opened this issue May 12, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@tbm
Copy link

tbm commented May 12, 2020

It seems multi-line code paragraphs were broken by commit 0091d1b.

For example:

-    import beancount.loader  
-    …  
-    entries, errors, options = beancount.loader.load\_file(‘myfile.ledger’)  
-    for entry in entries:  
-    …
+    `import beancount.loader … entries, errors, options = beancount.loader.load_file(‘myfile.ledger’) for entry in entries: …`
-    **easy\_install-3.4 pip  
-    **Make sure you invoke the version of easy\_install which matches your Python version, e.g. easy\_install-3.5 if you have Python 3.5 installed, or more.
+    **`easy_install-3.4 pip `**Make sure you invoke the version of easy\_install which matches your Python version, e.g. easy\_install-3.5 if you have Python
 3.5 installed, or more.
-    2015-11-20 price ITOT    95.46 USD
-    2015-11-20 price LQD    115.63 USD
-    2015-11-21 price USD   1.33495 CAD
-    …
+`2015-11-20 price ITOT 95.46 USD 2015-11-20 price LQD 115.63 USD 2015-11-21 price USD 1.33495 CAD …`
xuhcc added a commit that referenced this issue May 12, 2020
@xuhcc
Copy link
Collaborator

xuhcc commented May 12, 2020

I added a special rule for these cases, but the result is still not perfect. The parsing could be further improved by changing formatting in the google doc.

@tbm
Copy link
Author

tbm commented May 13, 2020

I added a special rule for these cases, but the result is still not perfect

Thanks!

The parsing could be further improved by changing formatting in the google doc.

What's broken about these entries in google doc? I checked the first and it looked ok? Intended (2 spaces) and font Consolidas.

(I don't have edit access to these documents at the moment but if you tell me what's broken I can fix once I get access)

@xuhcc
Copy link
Collaborator

xuhcc commented May 13, 2020

What's broken about these entries in google doc?

It's hard to say, but the solution may be similar to #11.

@xuhcc xuhcc added the bug Something isn't working label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants