Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix486 #504

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Fix486 #504

merged 2 commits into from
Jun 22, 2022

Conversation

MitchBradley
Copy link
Collaborator

There are a lot of cases to test:
M3 and M4 modes.
Switching from G1 to G0 and back, with and without axis words.
I used an LED as a proxy for a laser.

@Avataar120
Copy link
Contributor

Hi Mitch,

Thanks to have worked on my problem :)
I've patched it with much less lines of code 4 in one file and it's working fine for me.
Perhaps, it was not the best way to do it, but I didn't have to take several kind of movement into consideration

To Bart's question related to disable_with_s0 and , I'm not able to use it as it seems there is a real time issue on it ...
I don't know exactly how it works behind, but when I activate this option, when lightburn issues a G0 movement that therefore put PWM signal at 0, PWM goes to 0 immediately but even before end of the movement ... (clearly visible on the oscilloscope)

Resulting in not finished cut for instance.

@Avataar120
Copy link
Contributor

By the way, do you want me to test your fix on my machine with several of my complex files ?

@MitchBradley
Copy link
Collaborator Author

Most of the changed lines of code were cleanup. The ones that represent the core of the fix are:

            if (stateIsFeedrateMotion) {
                syncLaser = true;
            }

@MitchBradley
Copy link
Collaborator Author

Testing is always welcome. We will hold off merging this change pending your tests.

@Avataar120
Copy link
Contributor

OK will do tonight

@Avataar120
Copy link
Contributor

Working for me ! Thx again

@MitchBradley MitchBradley merged commit 6157286 into Devt Jun 22, 2022
@MitchBradley MitchBradley deleted the Fix486 branch September 23, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants