Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated deps @types/prettier #593

Closed
pcorpet opened this issue Apr 23, 2024 · 2 comments · Fixed by #594
Closed

Remove deprecated deps @types/prettier #593

pcorpet opened this issue Apr 23, 2024 · 2 comments · Fixed by #594

Comments

@pcorpet
Copy link
Contributor

pcorpet commented Apr 23, 2024

The package prettier now includes the types, and the @types/prettier is deprecated. Can you remove it from your deps please?

If you think it's valid, I can send a PR.
@bcherny
Copy link
Owner

bcherny commented Apr 23, 2024

Sure. Go for it!

pcorpet pushed a commit to pcorpet/json-schema-to-typescript that referenced this issue Apr 23, 2024
[Chore] Drop @types/prettier dependency.
f59921a 
It is now deprecated as the types are now part of the prettier lib.

Fixes bcherny#593
@pcorpet pcorpet mentioned this issue Apr 23, 2024
Merged
bcherny pushed a commit that referenced this issue Apr 23, 2024
@pcorpet
[Chore] Drop @types/prettier dependency. (#594)
13806bd 
It is now deprecated as the types are now part of the prettier lib.

Fixes #593

Co-authored-by: Pascal Corpet <[email protected]>
@gemyago
Copy link

gemyago commented Apr 24, 2024

would be good to have it released, it breaks our builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Chore] Drop @types/prettier dependency. pcorpet/json-schema-to-typescript
3 participants
@gemyago @bcherny @pcorpet