Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg data #14

Merged
merged 5 commits into from
Nov 30, 2021
Merged

Pkg data #14

merged 5 commits into from
Nov 30, 2021

Conversation

FrankBornais
Copy link
Contributor

  • Save param tables into the package
  • Replicate paper functions into the package

Copy link
Collaborator

@meztez meztez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, I thought about documenting calc_DD_m, Then I read deeper and came to the same conclusion. They are undefined in the paper. So no way to describe them properly.

Then I thought about indexing the internal dt. Looked at the calling functions, they already use match and the row numer is low.

I have nothing to say. You trained yourself well.

@meztez meztez merged commit 763fcde into main Nov 30, 2021
@meztez meztez deleted the pkg_data branch November 30, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants