Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement decryption for AEAD protected keys #1699

Closed
wants to merge 5 commits into from
Closed

Implement decryption for AEAD protected keys #1699

wants to merge 5 commits into from

Conversation

vanitasvitae
Copy link
Contributor

This PR adds support for decrypting AEAD protected OpenPGP secret keys.

TODO:

  • JcePBEProtectionRemoverFactory does not implement the new key recovery method, as it would require some ugly code duplication. I'm still thinking of a cleaner way to implement this.
  • Executing the test together with the other PGP related tests results in OutOfMemoryErrors. Running the test isolated however succeeds just fine.

@vanitasvitae vanitasvitae mentioned this pull request Jun 11, 2024
Closed
@vanitasvitae
pg:test: Increase max heap size to 3GB
a95ab27 
Fixes OOM errors when decrypting PGP keys using argon2 taking up over 2G memory
@jill-kleiber jill-kleiber self-assigned this Jun 27, 2024
@dghgit dghgit closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jill-kleiber jill-kleiber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vanitasvitae @dghgit @jill-kleiber