Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes of target dataset no longer empty #58

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Attributes of target dataset no longer empty #58

merged 2 commits into from
Feb 12, 2024

Conversation

forman
Copy link
Member

@forman forman commented Feb 10, 2024 •
edited
Loading

Closes #56

@forman forman changed the title Global metadata attributes of target dataset is no longer empty Attributes of target dataset no longer empty Feb 10, 2024
@forman forman self-assigned this Feb 10, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b654f6f) 99.83% compared to head (4c50302) 99.83%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          25       25           
  Lines        1211     1211           
=======================================
  Hits         1209     1209           
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forman forman requested a review from TonioF February 10, 2024 11:25
@forman forman marked this pull request as ready for review February 10, 2024 11:26
@forman forman requested review from thomasstorm and removed request for TonioF February 12, 2024 12:34
thomasstorm
thomasstorm approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@thomasstorm thomasstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please address my comment.

@forman forman merged commit c4f97d1 into main Feb 12, 2024
5 checks passed
@forman forman deleted the forman-56-no_gobal_attrs branch February 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasstorm thomasstorm thomasstorm approved these changes

Assignees

@forman forman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global metadata of target dataset is empty
2 participants
@forman @thomasstorm