Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos etc. #37

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Fix various typos etc. #37

merged 2 commits into from
Jan 26, 2024

Conversation

pont-us
Copy link
Member

@pont-us pont-us commented Jan 25, 2024

Closes #33 .

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e56991c) 99.81% compared to head (e7ac8d0) 99.81%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          23       23           
  Lines        1062     1062           
=======================================
  Hits         1060     1060           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pont-us pont-us marked this pull request as ready for review January 26, 2024 14:26
@pont-us pont-us requested a review from forman January 26, 2024 14:27
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, thanks very much! But I will reintroduce the version field as a public attribute, not an internal one.

@forman forman merged commit 4618003 into main Jan 26, 2024
5 checks passed
@pont-us pont-us deleted the pont-33-minor-fixes branch March 7, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix various typos etc.
2 participants