Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify operation for target attributes #59

Closed
forman opened this issue Feb 10, 2024 · 0 comments · Fixed by #61
Closed

Specify operation for target attributes #59

forman opened this issue Feb 10, 2024 · 0 comments · Fixed by #61
Labels
enhancement New feature or request

Comments

@forman
Copy link
Member

forman commented Feb 10, 2024

slice_dataset.to_zarr(target_store, mode="a", ...) replaces the existing global attributes in the target target_store by the attributes of slice_dataset. The resolution of #56 is currently that we must replace the slice_dataset attributes by the attributes of the existing target dataset.

However, users should be able to select the appropriate operation, e.g., a new config setting target_attrs_op with
values "first" (default), "last", "update".

@forman forman added the enhancement New feature or request label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant