forked from apache/flink
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FLINK-17308] Extract ExecutionGraphCache interface and rename impl i…
…nto DefaultExecutionGraphCache This commit extracts the ExecutionGraphCache interface from the implementation and renames the latter into DefaultExecutionGraphCache. Moreover, it introduces the NoOpExecutionGraphCache implementation which is used for the DocumentingDispatcherRestEndpoint.
- Loading branch information
1 parent
3635b54
commit 08025ec
Showing
12 changed files
with
240 additions
and
143 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
157 changes: 157 additions & 0 deletions
157
...rc/main/java/org/apache/flink/runtime/rest/handler/legacy/DefaultExecutionGraphCache.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http:https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.runtime.rest.handler.legacy; | ||
|
|
||
| import org.apache.flink.api.common.JobID; | ||
| import org.apache.flink.api.common.time.Time; | ||
| import org.apache.flink.runtime.executiongraph.AccessExecutionGraph; | ||
| import org.apache.flink.runtime.executiongraph.ArchivedExecutionGraph; | ||
| import org.apache.flink.runtime.webmonitor.RestfulGateway; | ||
| import org.apache.flink.util.Preconditions; | ||
|
|
||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
| import java.util.function.Function; | ||
|
|
||
| import static org.apache.flink.util.Preconditions.checkNotNull; | ||
|
|
||
| /** | ||
| * Default implementation of {@link ExecutionGraphCache}. | ||
| */ | ||
| public class DefaultExecutionGraphCache implements ExecutionGraphCache { | ||
|
|
||
| private final Time timeout; | ||
|
|
||
| private final Time timeToLive; | ||
|
|
||
| private final ConcurrentHashMap<JobID, ExecutionGraphEntry> cachedExecutionGraphs; | ||
|
|
||
| private volatile boolean running = true; | ||
|
|
||
| public DefaultExecutionGraphCache( | ||
| Time timeout, | ||
| Time timeToLive) { | ||
| this.timeout = checkNotNull(timeout); | ||
| this.timeToLive = checkNotNull(timeToLive); | ||
|
|
||
| cachedExecutionGraphs = new ConcurrentHashMap<>(4); | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| running = false; | ||
|
|
||
| // clear all cached AccessExecutionGraphs | ||
| cachedExecutionGraphs.clear(); | ||
| } | ||
|
|
||
| @Override | ||
| public int size() { | ||
| return cachedExecutionGraphs.size(); | ||
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<AccessExecutionGraph> getExecutionGraph(JobID jobId, RestfulGateway restfulGateway) { | ||
| return getExecutionGraphInternal(jobId, restfulGateway).thenApply(Function.identity()); | ||
| } | ||
|
|
||
| private CompletableFuture<ArchivedExecutionGraph> getExecutionGraphInternal(JobID jobId, RestfulGateway restfulGateway) { | ||
| Preconditions.checkState(running, "ExecutionGraphCache is no longer running"); | ||
|
|
||
| while (true) { | ||
| final ExecutionGraphEntry oldEntry = cachedExecutionGraphs.get(jobId); | ||
|
|
||
| final long currentTime = System.currentTimeMillis(); | ||
|
|
||
| if (oldEntry != null && currentTime < oldEntry.getTTL()) { | ||
| final CompletableFuture<ArchivedExecutionGraph> executionGraphFuture = oldEntry.getExecutionGraphFuture(); | ||
| if (!executionGraphFuture.isCompletedExceptionally()) { | ||
| return executionGraphFuture; | ||
| } | ||
| // otherwise it must be completed exceptionally | ||
| } | ||
|
|
||
| final ExecutionGraphEntry newEntry = new ExecutionGraphEntry(currentTime + timeToLive.toMilliseconds()); | ||
|
|
||
| final boolean successfulUpdate; | ||
|
|
||
| if (oldEntry == null) { | ||
| successfulUpdate = cachedExecutionGraphs.putIfAbsent(jobId, newEntry) == null; | ||
| } else { | ||
| successfulUpdate = cachedExecutionGraphs.replace(jobId, oldEntry, newEntry); | ||
| // cancel potentially outstanding futures | ||
| oldEntry.getExecutionGraphFuture().cancel(false); | ||
| } | ||
|
|
||
| if (successfulUpdate) { | ||
| final CompletableFuture<ArchivedExecutionGraph> executionGraphFuture = restfulGateway.requestJob(jobId, timeout); | ||
|
|
||
| executionGraphFuture.whenComplete( | ||
| (ArchivedExecutionGraph executionGraph, Throwable throwable) -> { | ||
| if (throwable != null) { | ||
| newEntry.getExecutionGraphFuture().completeExceptionally(throwable); | ||
|
|
||
| // remove exceptionally completed entry because it doesn't help | ||
| cachedExecutionGraphs.remove(jobId, newEntry); | ||
| } else { | ||
| newEntry.getExecutionGraphFuture().complete(executionGraph); | ||
| } | ||
| }); | ||
|
|
||
| if (!running) { | ||
| // delete newly added entry in case of a concurrent stopping operation | ||
| cachedExecutionGraphs.remove(jobId, newEntry); | ||
| } | ||
|
|
||
| return newEntry.getExecutionGraphFuture(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void cleanup() { | ||
| long currentTime = System.currentTimeMillis(); | ||
|
|
||
| // remove entries which have exceeded their time to live | ||
| cachedExecutionGraphs.values().removeIf( | ||
| (ExecutionGraphEntry entry) -> currentTime >= entry.getTTL()); | ||
| } | ||
|
|
||
| /** | ||
| * Wrapper containing the current execution graph and it's time to live (TTL). | ||
| */ | ||
| private static final class ExecutionGraphEntry { | ||
| private final long ttl; | ||
|
|
||
| private final CompletableFuture<ArchivedExecutionGraph> executionGraphFuture; | ||
|
|
||
| ExecutionGraphEntry(long ttl) { | ||
| this.ttl = ttl; | ||
| this.executionGraphFuture = new CompletableFuture<>(); | ||
| } | ||
|
|
||
| public long getTTL() { | ||
| return ttl; | ||
| } | ||
|
|
||
| public CompletableFuture<ArchivedExecutionGraph> getExecutionGraphFuture() { | ||
| return executionGraphFuture; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.