Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing bug fix #80

Merged
merged 6 commits into from
Oct 21, 2019
Merged

Routing bug fix #80

merged 6 commits into from
Oct 21, 2019

Conversation

emettely
Copy link
Contributor

Is your Pull Request request related to another issue in this repository ?
#79

Describe what the PR does
Fixes #79

State whether the PR is ready for review or whether it needs extra work
Ready

Additional context

Copy link
Contributor Author

@emettely emettely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, still don't understand why the hash routing for url doesn't work out of the box for Transcripts but works for Paper Edit.

@emettely emettely merged commit e21bc33 into master Oct 21, 2019
@emettely emettely deleted the routing-bug-fix branch October 21, 2019 14:04
@emettely
Copy link
Contributor Author

Hash router was used because of the demo version, which requires the hash router to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Demo page will not work with BrowserRouter
1 participant