Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Cloud formation attach queues/SNS to API Server #2

Open
4 tasks done
emettely opened this issue Jun 25, 2019 · 5 comments
Open
4 tasks done

AWS Cloud formation attach queues/SNS to API Server #2

emettely opened this issue Jun 25, 2019 · 5 comments
Assignees
@emettely
Labels
enhancement New feature or request
Projects
BBC News Labs - (0) Digital Paper Edi...

Comments

@emettely
Copy link
Contributor

emettely commented Jun 25, 2019 •
edited
Loading

  • Set up SNS in Cloudformation and deploy in Cosmos
  • The SNS will allow subscription from two queues (only one is in scope in this immediate project cycle)
  • The SNS message can be written to from the API Server e.g. /sns sends a message to SNS and succeeds.
  • The SNS asset is configurable via dotenv
@emettely emettely moved this from Backlog to Ready to start in BBC News Labs - (0) Digital Paper Edit - Sprint Board Jun 25, 2019
@emettely emettely self-assigned this Jun 25, 2019
@emettely emettely added the enhancement New feature or request label Jun 25, 2019
@emettely emettely moved this from Ready to start to In progress in BBC News Labs - (0) Digital Paper Edit - Sprint Board Jun 26, 2019
@emettely
Copy link
Contributor Author

SNS set up with write permissions from the API.
The policies to access the queues will be done as part of the Audio converting microservice set up: https://github.com/bbc/digital-paper-edit-audio-converter/issues/1

emettely pushed a commit that referenced this issue Jun 26, 2019
#2: Initial commit - has bake script updates and components
172db24
@pietrop
Copy link
Contributor

pietrop commented Jun 28, 2019 •
edited
Loading

What's the scope of this card, is it just the investigation figuring out?

see also this comment https://github.com/bbc/digital-paper-edit-audio-converter/issues/1#issuecomment-505455061 is this one of those 3 (eg 1 and 3?) ?

(cc @emettely )

@pietrop pietrop changed the title Figure out how to attach queues/SNS to API Server (in AWS Cloud formation) AWS Cloud formation attach queues/SNS to API Server Jun 28, 2019
@emettely
Copy link
Contributor Author

emettely commented Jun 28, 2019 •
edited
Loading

@pietrop
Copy link
Contributor

pietrop commented Jul 4, 2019

PR #3

This was referenced Jul 5, 2019
Draft
Merged
@nganthi nganthi moved this from In progress to Ready to review in BBC News Labs - (0) Digital Paper Edit - Sprint Board Jul 5, 2019
@emettely
Copy link
Contributor Author

emettely commented Jul 5, 2019

Screen Shot 2019-07-05 at 11 25 31

emettely added a commit that referenced this issue Jul 5, 2019
@emettely
No promise, but tests are working - related to issue #2 (#8)
4b3604e 
* #2: Initial commit - has bake script updates and components

* Fixed bakescript bug

* Bug fixes - missing .env file and missing fs import

* Adding tests, failing still

* Still broken, but refactored

* Clean up in general with test improvements

* Fixed tests

* ignoring vscode files

* Updating dependencies and adding eslint plugin for react as '[email protected] requires a peer of eslint-plugin-react@^7.14.2', also removing graphql

* React component convention to general js

* Adding console printing for sqs

* Removing duplicated files and updating the status

* override will fail the service

* Updates to package.json, removing fs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emettely emettely

Labels
enhancement New feature or request
Projects
No open projects
BBC News Labs - (0) Digital Paper Edi...
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pietrop @emettely