Get hostname in a cross-platform way #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.uname()[1] only works on Unix-like operating systems, socket.gethostname() gets the same data in a cross-platform way.
|
Hi, Very good point. I haven't tested it on windows but if it works for you and it's the recommended way to query the hostname anyway, then I see no harm. Will merge as soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.uname()[1] only works on Unix-like operating systems (and also truncates the hostname to 8 characters on some systems), socket.gethostname() gets the same data in a better cross-platform way.
In my case this was the only thing I needed to change to get this running on Windows (to collect inventory data)
Reference: https://docs.python.org/3/library/os.html#os.uname