Rework jobs and variants lists for a more responsive layout #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses unordered lists instead of tables
|
On the projects jobs pag, the SCM URL does not look well placed
On the variant page, I like the way we can navigate from one variant to another, but I would like the colors to be more explicit about which one is selected and which ones are "the others" Moreover, the "purple" colors for the variant env vars are a little disturbing, but this is just a personnal preference. |
When showing variant list, selected row is highlighted, and unselected rows are lightened
Some minor changes in color
| } | ||
|
|
||
| &.errored { | ||
| background: $line-background-selected-success-color; |
There was a problem hiding this comment.
Actually, there is an error here, success => errored
|
LGTM now 👍 |
julienvey
added a commit
that referenced
this pull request
Sep 29, 2015
Rework jobs and variants lists for a more responsive layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a big honky pull request, sorry for that !
The following screenshots show in a glance how the ui changed:
Home
Before
Long commit messages lead to this:
After
Project jobs
Same as home
Job
Before
Too many variant metas:
After
The variant metas scroll independently:
Variant
Before
After
No separate page for variants anymore: