Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject global job parameters #250

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

haklop
Copy link
Contributor

@haklop haklop commented Jun 9, 2015

Enable job parameters to be set on project side.

Can be use to defined default parameters values.

Add a new command: bzk project env

Usage: bzk project env  COMMAND [arg...]

View or modify a bazooka project environment variable

Commands:
  list         List project environment variables
  get          Get a specific project environment variable
  set          Set a specific project environment variable
  unset        Delete a specific project configuration key

bzk project env my-project A 5 sets the default value of A to 5 for the project my-project. This value is used if a job is started without specify a value for A.

Permutation is not yet possible (wip, it'll come on another PR). Permutations can only be generated by using bzk job start command.

@julienvey
Copy link
Member

Tested, LGTM

return res, err
}

func (c *ProjectEnv) SetEnv(id, key, value string) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/SetEnv/Set/

@jawher
Copy link
Contributor

jawher commented Jun 18, 2015

Just so we don't forget, we agreed with @haklop that project env should be multivalued, i.g:

bzk project env set GOMAXPROCS 1 2 3 4

@jawher
Copy link
Contributor

jawher commented Jun 18, 2015

And don't forget to update the doc to explain the 3 override levels: bazooka.yml -> project env -> job parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants