Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readme about kotlinc_opts and javac_opts #984

Conversation

asinbow
Copy link
Contributor

@asinbow asinbow commented Jun 6, 2023

As the title.

@google-cla
Copy link

google-cla bot commented Jun 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Comment on lines +248 to +249
kotlinc_opts = "//:kt_kotlinc_options_for_package_name",
javac_opts = "//:kt_javac_options_for_package_name",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to

"kotlinc_opts": attr.label(
doc = """Kotlinc options to be used when compiling this target. These opts if provided
will be used instead of the ones provided to the toolchain.""",
default = None,
providers = [_KotlincOptions],
mandatory = False,
),
"javac_opts": attr.label(
doc = """Javac options to be used when compiling this target. These opts if provided will
be used instead of the ones provided to the toolchain.""",
default = None,
providers = [_JavacOptions],
mandatory = False,
),
.

@Bencodes Bencodes merged commit f34b26a into bazelbuild:master Jun 6, 2023
nkoroste added a commit that referenced this pull request Jul 26, 2023
…idanceKotlin_upstream

* upstream/master: (51 commits)
  Expose ksp_version (#989)
  Bump quick guide to use v1.8 (#987)
  Fail CI if the docs are outdated (#961)
  Rename dev_io_bazel_rules_kotlin -> io_bazel_rules_kotlin (#973)
  update stardoc to 0.5.6 (#986)
  fix readme about kotlinc_opts and javac_opts (#984)
  Update README with KSP support (#983)
  Regenerate the docs (#980)
  Update the README.md with the latest dev override config (#981)
  Remove opts.release.bzl which is no longer being used (#982)
  Remove print warning from kt_download_local_dev_dependencies (#974)
  Avoid creating duplicate android_sdk_repositories (#978)
  Normalize label (#968)
  Generate koltinc options (#962)
  Restore neverlink on compiler. (#977)
  Use the mnemonic for worker keys (#976)
  Update KtLint to 0.49.1 (#970)
  Add support for -Xuse-fir-lt (#972)
  Support -Xenable-incremental-compilation (#971)
  Update to Kotlin 1.8.21 (#969)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants