Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate usages of deprecated JavaInfo fields #1005

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

hvadehra
Copy link
Member

@hvadehra hvadehra commented Aug 11, 2023

  • transitive_deps was an alias for transitive_compile_time_jars
  • transitive_runtime_deps was an alias for transitive_runtime_jars

The fields were deprecated in 2021, and are dropped in Bazel@HEAD

Fixes #1003

transitive_deps was an alias for transitive_compile_time_jars transitive_runtime_deps was an alias for transitive_runtime_jars

The fields were deprecated in 2021, and are dropped in Bazel@HEAD

Fixes bazelbuild#1003
@hvadehra hvadehra marked this pull request as ready for review August 11, 2023 07:12
@hvadehra hvadehra changed the title Migrate usages deprecated JavaInfo fields Migrate usages of deprecated JavaInfo fields Aug 11, 2023
@Bencodes Bencodes merged commit 20ff6ac into bazelbuild:master Aug 11, 2023
1 check passed
@hvadehra hvadehra deleted the hvadehra-patch-1 branch August 11, 2023 07:33
@meteorcloudy
Copy link
Member

@Bencodes Can you please help creating a new release for rules_kotlin so that we can fix other dependent projects?

@Bencodes
Copy link
Collaborator

Bencodes commented Sep 7, 2023

Can you please help creating a new release for rules_kotlin so that we can fix other dependent projects?

@meteorcloudy a 1.8.1 release has been published with the fixes for the deprecated provider methods included.

@meteorcloudy
Copy link
Member

Awesome, thank you!
@sgowroji Can you follow up ;)

nkoroste added a commit to nkoroste/rules_kotlin that referenced this pull request Sep 15, 2023
…idanceKotlin_upstream

* upstream/master:
  Move the KSP and compiler target definitions into rules_kotlin (bazelbuild#1014)
  Avoid running java_common#compile against KSP generated outputs (bazelbuild#990)
  Update kt_java_stub_template to 6.2.1 (bazelbuild#992)
  Disable strict deps for Android example (bazelbuild#1013)
  Group the all_tests jobs together in presubmit.yml (bazelbuild#1008)
  Add rules_java 6.4.0 (bazelbuild#1010)
  Update Bazel to 6.3.2 (bazelbuild#1007)
  Update rules_jvm_external to 5.3 (bazelbuild#1009)
  Migrate usages of deprecated `JavaInfo` fields (bazelbuild#1005)
  Remove unnecessary Java runtime dependencies (bazelbuild#1000)
jbarr21 pushed a commit to uber-common/rules_kotlin that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants