Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label_typed_build_setting example not working #247

Closed
gregestren opened this issue May 23, 2022 · 0 comments · Fixed by #248
Closed

label_typed_build_setting example not working #247

gregestren opened this issue May 23, 2022 · 0 comments · Fixed by #248
Assignees
Labels

Comments

@gregestren
Copy link
Collaborator

gregestren commented May 23, 2022

The README at https://github.com/bazelbuild/examples/tree/main/configurations/label_typed_build_setting says:

To test it out, cd to this directory and run the following:

$ bazel build :my-toolbox # "Using a hammer."

But this fails:

BUILD:8:8: every rule of type toolbox implicitly depends upon the target '//configurations/label_typed_build_setting:tool',
but this target could not be found because of: no such package 'configurations/label_typed_build_setting': BUILD file
not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
@gregestren gregestren added the bug label May 23, 2022
@gregestren gregestren self-assigned this May 23, 2022
gregestren added a commit to gregestren/examples that referenced this issue May 24, 2022
bazelbuild@e5e9d05 refactored the WORKSPACES (so different labels are required now).

Fixes bazelbuild#247
gregestren added a commit that referenced this issue May 27, 2022
* Fix broken example.

e5e9d05 refactored the WORKSPACES (so different labels are required now).

Fixes #247

* Re-enable configuration tests.

* Fix CI bugs.

* Further CI fix.

* Disable tests (there are none).

* Make Windows consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant