-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.14 sometimes hangs before running any actions #5336
Comments
Hi, I'm happy to help debug this further. Can you let me know what additional info I can provide? I suspect it's something like in certain cases the docker process is waiting to read from stdin or something like that? |
For reference. |
Baseline: 5c3f5c9 Cherry picks: + f96f037: Windows, Java launcher: Support jar files under different drives + ff8162d: sh_configure.bzl: FreeBSD is also a known platform + 7092ed3: Remove unneeded exec_compatible_with from local_sh_toolchain + 57bc201: Do not autodetect C++ toolchain when BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 is present + 35a78c0: remote: recursively delete incomplete downloaded output directory. + 3c9cd82: distfile: pack the archives needed later in the build + 27487c7: Slightly refactor SpawnAction to improve env handling + 1b333a2: Fix Cpp{Compile,Link}Action environment and cache key computation + 3da8929: Make SymlinkTreeAction properly use the configuration's environment + eca7b81: Add a missing dependency from checker framework dataflow to javacutils + 10a4de9: Release 0.14.0 (2018-06-01) + 4b80f24: Add option to enable Docker sandboxing. + 6b16352: Allow disabling the simple blob caches via CLI flag overrides. Bug fix for [#5336](#5336) Bug fix fot [#5308](#5308)
Baseline: 5c3f5c9 Cherry picks: + f96f037: Windows, Java launcher: Support jar files under different drives + ff8162d: sh_configure.bzl: FreeBSD is also a known platform + 7092ed3: Remove unneeded exec_compatible_with from local_sh_toolchain + 57bc201: Do not autodetect C++ toolchain when BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 is present + 35a78c0: remote: recursively delete incomplete downloaded output directory. + 3c9cd82: distfile: pack the archives needed later in the build + 27487c7: Slightly refactor SpawnAction to improve env handling + 1b333a2: Fix Cpp{Compile,Link}Action environment and cache key computation + 3da8929: Make SymlinkTreeAction properly use the configuration's environment + eca7b81: Add a missing dependency from checker framework dataflow to javacutils + 10a4de9: Release 0.14.0 (2018-06-01) + 4b80f24: Add option to enable Docker sandboxing. + 6b16352: Allow disabling the simple blob caches via CLI flag overrides. Bug fix for [bazelbuild#5336](bazelbuild#5336) Bug fix fot [bazelbuild#5308](bazelbuild#5308)
Since the 0.14.1 release is out, can this be closed? |
If you want? Though don't you have to figure out why it hangs? |
That's a workaround, not a fix. What if I want to use the feature? |
Fair point, then I'd change the title of the bug and lower the priority. Assignees? Wdyt? |
It'll be taken care of by @philwo when he's back at work. |
Awesome. We definitely need this feature...
…On Mon, 25 Jun 2018 at 18:14 lberki ***@***.***> wrote:
It'll be taken care of by @philwo <https://github.com/philwo> when he's
back at work.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5336 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIFwPgm4IbNqN-BY48qtkDHtU_H-OCks5uAP5egaJpZM4Uc2Pz>
.
|
@mattklein123 @ittaiz If I checked the code and I don't think it ever waits for stdin. The "info" command makes a single API request to the Docker daemon, decodes the result and prints it (https://github.com/moby/moby/blob/master/client/info.go). Common reasons for hanging commands that do network requests are a wrongly configured hostname / DNS setup. I notice that your "Name" output in Can you still reproduce the |
There are two things we can do on Bazel's side:
There's nothing Bazel can do to fix or workaround the hang itself, though. |
|
Baseline: 5c3f5c9 Cherry picks: + f96f037: Windows, Java launcher: Support jar files under different drives + ff8162d: sh_configure.bzl: FreeBSD is also a known platform + 7092ed3: Remove unneeded exec_compatible_with from local_sh_toolchain + 57bc201: Do not autodetect C++ toolchain when BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 is present + 35a78c0: remote: recursively delete incomplete downloaded output directory. + 3c9cd82: distfile: pack the archives needed later in the build + 27487c7: Slightly refactor SpawnAction to improve env handling + 1b333a2: Fix Cpp{Compile,Link}Action environment and cache key computation + 3da8929: Make SymlinkTreeAction properly use the configuration's environment + eca7b81: Add a missing dependency from checker framework dataflow to javacutils + 10a4de9: Release 0.14.0 (2018-06-01) + 4b80f24: Add option to enable Docker sandboxing. + 6b16352: Allow disabling the simple blob caches via CLI flag overrides. Bug fix for [bazelbuild#5336](bazelbuild#5336) Bug fix fot [bazelbuild#5308](bazelbuild#5308)
Given the age of this report... and that things might have changed... I'll have to close due to the apparent difficulty in reproducing this. Please let me know if think this is still a problem. |
Stack trace looks like this:
https://gist.github.com/mattklein123/070fbfe5c49d52b0457e9c694c148380
It appears that we unconditionally run
docker info
on every build, and if that hangs, we also hang. There is a fix at HEAD (4b80f24) but that doesn't help 0.14 by itself.The text was updated successfully, but these errors were encountered: