Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to select different prompt types #81

Closed
wants to merge 2 commits into from

Conversation

csfh
Copy link

@csfh csfh commented Jun 10, 2024

Hi @dhh

In this PR I've added a prompts directory similar to fonts and themes. This will allow a user to change to different kinds of prompts.

I don't suggest Omakub should ship with a ton of prompts, but perhaps a couple of standard ones, the default you have, something that looks like Pure, or my own "Avatar"-style and perhaps even a Powerline.

Additionally, I've also made some changes to that Omakub uses $OMAKUB_PATH throughout the code, this allowed me to develop and enable a local version of Omakub next to the one installed in ~/.local/share/omakub.

Last thoughts, it might make sense to rename OMAKUB_PATH to OMAKUB_HOME - while this is non essential, it does seem like _HOME suffix is more consistent with more libraries in my experiences.

For your convenience I've included a screenshot.

omakub-prompt

Lastly, thanks for creating this. Omakub has renewed my interest in a Linux based setup.

@csfh
Copy link
Author

csfh commented Jun 10, 2024

In the unlikely event you decide to merge this 😉 - please let me know first since I didn't set up my gpg key yet. I'd like to amend the commits with signatures if they're getting merged.

I was also thinking that, if configuring prompts is interesting then we should have a discussion about which to add to this branch before it's merged.

@csfh
Copy link
Author

csfh commented Jun 11, 2024

Signed both commits.

@dhh
Copy link
Member

dhh commented Jun 12, 2024

@csfh Can you show what the different prompts look like with some screenshots? Thanks for working on this!

@csfh
Copy link
Author

csfh commented Jun 12, 2024

Yeah. Let me a maybe add two more for a total of four. I'm not a big prompt-aficionado, but I'll try to cover some of the important ground.

@csfh
Copy link
Author

csfh commented Jun 12, 2024

This is "Avatar" - a prompt inspired by Pure which is for zsh, https://github.com/sindresorhus/pure.

omakub-prompt-avatar

@mandarvaze
Copy link

@csfh Have you considered https://starship.rs/ for prompts ? It is far superior and cross platform and works will all the shells

@csfh
Copy link
Author

csfh commented Jul 3, 2024

Good idea. I will look at starship too!

@csfh csfh closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants