Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated docker compose version #869

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

nickhammond
Copy link
Contributor

@nickhammond nickhammond commented Jun 27, 2024

The top-level docker compose version property is no longer needed, this PR removes it.

Ref: https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-and-name-top-level-elements

Running tests is currently outputting a bunch of these WARN lines:

WARN[0000] /Users/n/src/github/kamal/test/integration/docker-compose.yml: `version` is obsolete

@jeremy jeremy merged commit 85a2926 into basecamp:main Jun 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants