Fixes property lookup on null if promobarContent node doesn't exist #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
approved these changes
Oct 4, 2016
There was a problem hiding this comment.
Ah, makes sense. Keep in mind that even things like a className change or something would invalidate the cache in this case. Probably not a huge deal or common scenario.
The design here was intended to force a user to provide content to the cache instead of relying on assumption about the content in the event that assumption could be wrong. This seems to be a pretty safe assumption though.
Idk why you're not on this repo, I'll add you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.