Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWA functionality (splash screen, maskable icons etc.) #128

Merged
merged 3 commits into from
Jan 3, 2021

Conversation

lorenz-h
Copy link
Contributor

Adresses #127 .

@lorenz-h lorenz-h marked this pull request as draft December 31, 2020 12:06
@lorenz-h
Copy link
Contributor Author

lorenz-h commented Dec 31, 2020

So far I have just added some required tags to the webmanifest and added it to index.html. I think it makes sense to have one default manifest for all views (and storing it in the default view just like the apple touch icons).

The next step will be to generate a number of icons for the app and add a service worker. @tuomashamalainen could you add the icons? I added you as a collaborator to my fork.

@lorenz-h lorenz-h changed the title Work in Progress: Add PWA functionality (service worker, offline page, maskable icons etc.) Work in Progress: Add PWA functionality (splash screen, maskable icons etc.) Dec 31, 2020
@lorenz-h
Copy link
Contributor Author

I generated a maskable icon from the existing apple touch icon. The icons 300x300px resolution should be sufficient.

@lorenz-h lorenz-h marked this pull request as ready for review December 31, 2020 15:57
@lorenz-h lorenz-h changed the title Work in Progress: Add PWA functionality (splash screen, maskable icons etc.) Add PWA functionality (splash screen, maskable icons etc.) Dec 31, 2020
@tuomashamalainen
Copy link
Collaborator

Thanks for your work on this so far, I'll fold it in.

So far I have just added some required tags to the webmanifest and added it to index.html. I think it makes sense to have one default manifest for all views (and storing it in the default view just like the apple touch icons).

For now this works. The use case for "views" is having different interfaces for different form factors (e.g. I have one that's meant to be used with a Beosound 5) or customised layouts for OEM partnerships. "Default" will always be the general-purpose UI for most devices.

@tuomashamalainen tuomashamalainen merged commit 14166f7 into bang-olufsen:master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants