Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compose implementation #8

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Compose implementation #8

merged 3 commits into from
Mar 8, 2021

Conversation

banasiak
Copy link
Owner

@banasiak banasiak commented Mar 6, 2021

No description provided.

justintuchek
justintuchek approved these changes Mar 6, 2021
View reviewed changes
Copy link
Collaborator

@justintuchek justintuchek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't ran locally yet but some initial feedback

app/src/main/java/app/onlysans/android/typeface/TypefaceWrapper.kt Outdated Show resolved Hide resolved
app/src/main/java/app/onlysans/android/ui/theme/Color.kt Show resolved Hide resolved
app/src/main/java/app/onlysans/android/ui/MainViewModel.kt Show resolved Hide resolved
@banasiak banasiak merged commit 46080f3 into master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justintuchek justintuchek justintuchek approved these changes

Assignees

@justintuchek justintuchek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banasiak @justintuchek