Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: always run cryptsetup hook with secure boot #3485

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakogut
Copy link
Contributor

@jakogut jakogut commented Jul 30, 2024

Init hooks specify an *_enabled function that determines whether or not the hook is skipped during boot. Hooks are run by the "init" script, shipped as part of the initramfs-framework poky recipe.

Several conditions were checked in the cryptsetup-efi-tpm enablement function, some of which could cause the hook to be improperly skipped.

Force the hook to run when in secure boot user mode, as we want any failure in the hook's run function to be detected and abort the boot.

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Init hooks specify an *_enabled function that determines whether or not
the hook is skipped during boot. Hooks are run by the "init" script,
shipped as part of the initramfs-framework poky recipe.

Several conditions were checked in the cryptsetup-efi-tpm enablement
function, some of which could cause the hook to be improperly skipped.

Force the hook to run when in secure boot user mode, as we want any
failure in the hook's run function to be detected and abort the boot.

Change-type: patch
Signed-off-by: Joseph Kogut <[email protected]>
Copy link

Website deployed to CF Pages, 👀 preview link https://1b897eb9.balena-os.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant